lkml.org 
[lkml]   [2022]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema
From
On 11/11/2022 12:35, Krzysztof Kozlowski wrote:
> The APR/GPR nodes are organized like:
>
> apr-or-gpr-device-node <- qcom,apr.yaml
> apr-gpr-service@[0-9] <- qcom,apr.yaml
> service-specific-components <- /schemas/sound/qcom,q6*.yaml
>

(...)

> +additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
> index 0a7a34cb2497..9302ffe567d6 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
> @@ -80,115 +80,13 @@ properties:
> '#size-cells':
> const: 0
>
> -#APR/GPR Services
> patternProperties:
> "^service@[1-9a-d]$":
> type: object
> + $ref: /schemas/soc/qcom/qcom,apr-services.yaml
> + additionalProperties: true
> description:
> - APR/GPR node's client devices use subnodes for desired static port services.
> -
> - properties:
> - compatible:
> - enum:
> - - qcom,q6core
> - - qcom,q6asm
> - - qcom,q6afe
> - - qcom,q6adm
> - - qcom,q6apm
> - - qcom,q6prm

I think that this piece could stay here. Otherwise we allow any
compatible which matches the qcom,apr-services.yaml binding, but that's
easy to achieve.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-15 11:23    [W:0.155 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site