Messages in this thread | | | Date | Fri, 11 Nov 2022 16:15:28 +0000 | Subject | Re: [PATCH 00/10] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 | From | Srinivas Kandagatla <> |
| |
On 11/11/2022 11:35, Krzysztof Kozlowski wrote: > Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought > some changes to APR/GPR services bindings. These bindings are part of > qcom,apr.yaml: > > apr-or-gpr-device-node <- qcom,apr.yaml > apr-gpr-service@[0-9] <- qcom,apr.yaml > service-specific-components <- /schemas/sound/qcom,q6*.yaml > > The schema for services (apr-gpr-service@[0-9]) already grows considerably and > is still quite not specific. It allows several incorrect combinations, like > adding a clock-controller to a APM device. Restricting it would complicate the > schema even more. Bringing new support for sound on Qualcomm SM8450 and > SC8280XP SoC would grow it as well.
Why would this grow? All the dsp services are static and they will not change per SoC unless there is a total firmware change in DSP.
> > Refactor the bindings before extending them for Qualcomm SM8450 SoC.
I dont understand this bit, what is SoC audio support to do with DSP bindings. DSP bindings should be totally independent of this. >
--srini
> Best regards, > Krzysztof > > Krzysztof Kozlowski (10): > ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450 > ASoC: dt-bindings: qcom,apr: Split services to shared schema > ASoC: dt-bindings: qcom,q6afe: Split to separate schema > ASoC: dt-bindings: qcom,q6apm: Split to separate schema > ASoC: dt-bindings: qcom,q6adm: Split to separate schema > ASoC: dt-bindings: qcom,q6asm: Split to separate schema > ASoC: dt-bindings: qcom,q6prm: Split to separate schema > ASoC: dt-bindings: qcom,q6core: Split to separate schema > ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema > ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node > > .../bindings/soc/qcom/qcom,apr-services.yaml | 54 ++++++++ > .../bindings/soc/qcom/qcom,apr.yaml | 119 ++---------------- > .../bindings/sound/qcom,q6adm-routing.yaml | 22 +--- > .../devicetree/bindings/sound/qcom,q6adm.yaml | 51 ++++++++ > .../devicetree/bindings/sound/qcom,q6afe.yaml | 69 ++++++++++ > .../bindings/sound/qcom,q6apm-dai.yaml | 19 +-- > .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 32 +++++ > .../devicetree/bindings/sound/qcom,q6apm.yaml | 67 ++++++++++ > .../bindings/sound/qcom,q6asm-dais.yaml | 48 +++---- > .../devicetree/bindings/sound/qcom,q6asm.yaml | 68 ++++++++++ > .../bindings/sound/qcom,q6core.yaml | 39 ++++++ > .../sound/qcom,q6dsp-lpass-clocks.yaml | 40 +----- > .../sound/qcom,q6dsp-lpass-ports.yaml | 57 ++------- > .../devicetree/bindings/sound/qcom,q6prm.yaml | 50 ++++++++ > MAINTAINERS | 2 +- > 15 files changed, 477 insertions(+), 260 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6core.yaml > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6prm.yaml >
| |