lkml.org 
[lkml]   [2022]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v12 04/17] riscv: Add vector feature to compile
From
On 11/13/22 08:16, Conor.Dooley@microchip.com wrote:
>>> +config VECTOR
>>> + bool "VECTOR support"
>>> + depends on GCC_VERSION >= 120000 || CLANG_VERSION >= 130000
>>> + default n
>>> + help
>>> + Say N here if you want to disable all vector related procedure
>>> + in the kernel.
>>> +
>>> + If you don't know what to do here, say Y.
>>> +
>>> +endmenu
>> "VECTOR" is not really consistent to how the other configs are named;
>> RISCV_ISA_V, RISCV_ISA_VECTOR, RISCV_VECTOR?
> It'd be RISCV_ISA_V to match the others single letter extentions, right?

Yep.

> The toolchain dependency check here also seems rather naive.

Indeed. I can build the code just fine with gcc-11 (and gcc-12),
although my reworked patcheset doesn't include all the orig patches
including the in-kernel xor stuff.

-Vineet



\
 
 \ /
  Last update: 2022-11-15 18:39    [W:0.584 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site