Messages in this thread | | | Date | Tue, 8 Nov 2022 17:22:40 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v12 04/17] riscv: Add vector feature to compile |
| |
On Tue, Nov 08, 2022 at 09:17:26AM -0800, Vineet Gupta wrote: > On 11/7/22 23:56, Conor Dooley wrote: > > On Mon, Nov 07, 2022 at 04:04:28PM -0800, Vineet Gupta wrote: > > > +CC Andy, Conor > > > > > > On 11/7/22 09:21, Björn Töpel wrote: > > > > > +config VECTOR > > > > > + bool "VECTOR support" > > > > > + depends on GCC_VERSION >= 120000 || CLANG_VERSION >= 130000 > > > > > + default n > > > > > + help > > > > > + Say N here if you want to disable all vector related procedure > > > > > + in the kernel. > > > > > + > > > > > + If you don't know what to do here, say Y. > > > > > + > > > > > +endmenu > > > > "VECTOR" is not really consistent to how the other configs are named; > > > > RISCV_ISA_V, RISCV_ISA_VECTOR, RISCV_VECTOR? > > > > > > Good point, I've changed it to RISCV_ISA_V to keep it consistent with > > > existing RISCV_ISA_C. > > > > Hey Vineet, kinda randomly replying here but the wording makes it look > > like you're going to take this patchset on? > > If so, please check out v10 (think it was from April) as there are some > > comments on that version that IIRC remain un-resolved. > > Sure thing. Although I only see a few from Christoph and kernel build bot.
Yup, they were minor - I just don't wanna see them get lost :)
| |