Messages in this thread | | | Date | Sat, 12 Nov 2022 14:36:23 +0300 | Subject | Re: [PATCH 14/14] phy: qcom-qmp-combo: add support for updated sc8280xp binding | From | Dmitry Baryshkov <> |
| |
On 11/11/2022 12:24, Johan Hovold wrote: > Add support for the new SC8280XP binding. > > Note that the binding does not try to describe every register subregion > and instead the driver holds the corresponding offsets. > > Also note that (possibly) unlike on earlier platforms, the TX registers > are used by both the USB and DP implementation. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 143 ++++++++++++++++++++-- > 1 file changed, 133 insertions(+), 10 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 0a4d53e6c586..544a7e55bf14 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -798,9 +798,25 @@ static const u8 qmp_dp_v5_voltage_swing_hbr_rbr[4][4] = { > > struct qmp_combo; > > +struct qmp_combo_offsets { > + u16 com; > + u16 txa; > + u16 rxa; > + u16 txb; > + u16 rxb;
Yes, txa/txb are more in spite of the vendor headers. I'd sill suggest to use tx/tx2 and rx/rx2 as used everywhere in the QMP driver.
> + u16 usb3_serdes; > + u16 usb3_pcs_misc; > + u16 usb3_pcs; > + u16 usb3_pcs_usb; > + u16 dp_serdes; > + u16 dp_dp_phy; > +}; > + -- With best wishes Dmitry
| |