lkml.org 
[lkml]   [2022]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC 10/10] mm/hugetlb: Comment at rest huge_pte_offset() places
From
Date
On Oct 30, 2022, at 2:30 PM, Peter Xu <peterx@redhat.com> wrote:

> + /* With vma lock held, safe without RCU */
> src_pte = huge_pte_offset(src, addr, sz);

Just another option to consider: you can create an inline function
huge_pte_offset_locked_mm(), which would do the lockdep_assert_held_*().

I personally would prefer it, since it would clarify exactly the lock you
care about and "make the code document itself”.

\
 
 \ /
  Last update: 2022-11-01 06:39    [W:0.221 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site