| Date | Tue, 1 Nov 2022 16:49:20 -0500 | Subject | Re: [PATCH 11/30] greybus: svc: Use kstrtobool() instead of strtobool() | From | Alex Elder <> |
| |
On 11/1/22 4:13 PM, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Looks OK to me.
Reviewed-by: Alex Elder <elder@linaro.org>
> --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/greybus/svc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/greybus/svc.c b/drivers/greybus/svc.c > index 56d2b44d6fef..16cced80867a 100644 > --- a/drivers/greybus/svc.c > +++ b/drivers/greybus/svc.c > @@ -7,6 +7,7 @@ > */ > > #include <linux/debugfs.h> > +#include <linux/kstrtox.h> > #include <linux/workqueue.h> > #include <linux/greybus.h> > > @@ -83,7 +84,7 @@ static ssize_t watchdog_store(struct device *dev, > int retval; > bool user_request; > > - retval = strtobool(buf, &user_request); > + retval = kstrtobool(buf, &user_request); > if (retval) > return retval; >
|