Messages in this thread | | | Date | Wed, 5 Oct 2022 18:02:20 +0200 | Subject | Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators | From | Krzysztof Kozlowski <> |
| |
On 05/10/2022 16:57, Alexandre Mergnat wrote: > From: Fabien Parent <fparent@baylibre.com> > > Add YAML schema for the MediaTek MT6357 regulators. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > .../regulator/mediatek,mt6357-regulator.yaml | 284 +++++++++++++++++++++ > 1 file changed, 284 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > new file mode 100644 > index 000000000000..83ce2cf287dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml > @@ -0,0 +1,284 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6357-regulator.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT6357 Regulators > + > +maintainers: > + - Fabien Parent <fparent@baylibre.com>
The email might be not correct.
> + - Alexandre Mergnat <amergnat@baylibre.com> > + > +description: | > + The MT6357 PMIC provides 5 BUCK and 29 LDO. > + Regulators and nodes are named according to the regulator type: > + buck-<name> and ldo-<name>. > + MT6357 regulators node should be sub node of the MT6397 MFD node. > + > +patternProperties: > + "^buck-v(core|modem|pa|proc|s1)$": > + type: object > + $ref: "regulator.yaml#"
Drop quotes.
> + > + properties: > + regulator-name: > + pattern: "^v(core|modem|pa|proc|s1)$"
Why enforcing particular name of the regulator?
Both comments apply to all other cases.
Best regards, Krzysztof
| |