lkml.org 
[lkml]   [2022]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators
From
On 11/10/2022 05:30, Alexandre Mergnat wrote:
> Hi Krzysztof,
>
> Thanks for your review !
>
> >> +
> >> +    properties:
> >> +      regulator-name:
> >> +        pattern: "^v(core|modem|pa|proc|s1)$"
> >
> > Why enforcing particular name of the regulator?
>
> The regulator names are forced to match with the datasheet names.
>
> I think it's a good practice to increase visibility between HW & SW.

Enforcing is not a good practice.

>
> Also, that keep consistency with other Mediatek PMIC schema.

So there is a bad practice and instead of fixing it, you align to it... No.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-10-11 14:07    [W:0.087 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site