Messages in this thread | | | Date | Thu, 27 Oct 2022 18:41:56 +0300 | From | Vladimir Oltean <> | Subject | Re: [RFC net-next 1/2] dt-bindings: net: dsa: add bindings for GSW Series switches |
| |
Hi Camel,
On Tue, Oct 25, 2022 at 03:52:40PM +0200, Camel Guo wrote: > +additionalProperties: true
I don't think the switch schema should have additionalProperties: true. Only shared schemas should. WHat should be here is "unevaluatedProperties: false".
> + port@5 { > + reg = <5>; > + label = "cpu";
Please drop label = "cpu" for the CPU port, it is not needed/not parsed.
> + ethernet = <ð0>; > + phy-mode = "rgmii-id"; > + > + fixed-link { > + speed = <1000>; > + full-duplex; > + pause; > + }; > + }; > + };
| |