Messages in this thread | | | Date | Wed, 26 Oct 2022 18:00:20 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 3/5] EDAC/qcom: Get rid of hardcoded register offsets |
| |
On Thu, Aug 25, 2022 at 10:08:57AM +0530, Manivannan Sadhasivam wrote: > The LLCC EDAC register offsets varies between each SoC. Hardcoding the > register offsets won't work and will often result in crash due to > accessing the wrong locations. > > Hence, get the register offsets from the LLCC driver matching the > individual SoCs. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/edac/qcom_edac.c | 116 ++++++++++++++--------------- > include/linux/soc/qcom/llcc-qcom.h | 6 -- > 2 files changed, 58 insertions(+), 64 deletions(-)
I can't take those:
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/llcc-qcom.ko] undefined! make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1 make: *** [Makefile:1944: modpost] Error 2
You'd have to rediff them against latest Linus -rc tag and test them properly.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |