lkml.org 
[lkml]   [2022]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] edac: fix period calculation in edac_device_reset_delay_period()
Date
Fix period calculation in case user sets a value of 1000.
The input of round_jiffies_relative() should be in jiffies and not in
milli-seconds.

Signed-off-by: Eliav Farber <farbere@amazon.com>
---
v2 --> v1:
- Fix the bug without modifying jiffs which is used to set
edac_dev->delay.

drivers/edac/edac_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 19522c568aa5..e944dd9b3593 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -398,13 +398,13 @@ void edac_device_reset_delay_period(struct edac_device_ctl_info *edac_dev,
{
unsigned long jiffs = msecs_to_jiffies(value);

- if (value == 1000)
- jiffs = round_jiffies_relative(value);
-
edac_dev->poll_msec = value;
edac_dev->delay = jiffs;

- edac_mod_work(&edac_dev->work, jiffs);
+ if (value == 1000)
+ edac_mod_work(&edac_dev->work, round_jiffies_relative(jiffs));
+ else
+ edac_mod_work(&edac_dev->work, jiffs);
}

int edac_device_alloc_index(void)
--
2.37.1
\
 
 \ /
  Last update: 2022-10-20 14:45    [W:0.069 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site