Messages in this thread Patch in this message | | | From | Dario Binacchi <> | Subject | [PATCH] clk: ti: mux: don't free `parent_names' on kzalloc() failure | Date | Mon, 17 Oct 2022 18:46:46 +0200 |
| |
Although no operation is performed by kfree() on a NULL pointer, it's however suboptimal and semantically wrong doing it.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
drivers/clk/ti/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ti/mux.c b/drivers/clk/ti/mux.c index 46b45b3e8319..1f924db2ad98 100644 --- a/drivers/clk/ti/mux.c +++ b/drivers/clk/ti/mux.c @@ -182,7 +182,7 @@ static void of_mux_clk_setup(struct device_node *node) } parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL); if (!parent_names) - goto cleanup; + return; of_clk_parent_fill(node, parent_names, num_parents); -- 2.32.0
| |