Messages in this thread | | | Date | Sat, 15 Oct 2022 14:34:32 +0200 | Subject | Re: [PATCH] speakup: remove usage of non-standard u_char | From | Yureka <> |
| |
On 10/11/22 08:17, Greg KH wrote: > On Tue, Oct 11, 2022 at 02:17:43AM +0200, Yureka wrote: >> From: Yureka Lilian <yuka@yuka.dev> >> >> This code is included in the build tools makemapdata and genmap, and it >> expects that libc exposes a definition of u_char. But u_char is not >> defined in either C or POSIX standards, and some systems don't have it. >> Namely this breaks the build on hosts using musl libc, because musl only >> exposes u_char if _GNU_SOURCE is defined. >> >> Signed-off-by: Yureka Lilian <yuka@yuka.dev> >> --- >> drivers/accessibility/speakup/utils.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h >> index 4bf2ee8ac..4ce9a12f7 100644 >> --- a/drivers/accessibility/speakup/utils.h >> +++ b/drivers/accessibility/speakup/utils.h >> @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info) >> >> static inline struct st_key *hash_name(char *name) >> { >> - u_char *pn = (u_char *)name; >> + unsigned char *pn = (unsigned char *)name; >> int hash = 0; >> >> while (*pn) { >> -- >> 2.37.3 > > Hi, > > This is the friendly semi-automated patch-bot of Greg Kroah-Hartman. > You have sent him a patch that has triggered this response. > > Right now, the development tree you have sent a patch for is "closed" > due to the timing of the merge window. Don't worry, the patch(es) you > have sent are not lost, and will be looked at after the merge window is > over (after the -rc1 kernel is released by Linus). > > So thank you for your patience and your patches will be reviewed at this > later time, you do not have to do anything further, this is just a short > note to let you know the patch status and so you don't worry they didn't > make it through. > > thanks, > > greg k-h's patch email bot
I noticed in hindsight this patch might be suitable for the 6.0.x stable line as well, since it is a build fix with otherwise seemingly little impact. Let me know if I should do anything to get it in the queue for stable/fix reviews.
Thanks,
Yureka
| |