Messages in this thread | | | Date | Wed, 9 Nov 2022 15:20:55 +0100 | From | Greg KH <> | Subject | Re: [PATCH] speakup: remove usage of non-standard u_char |
| |
On Tue, Oct 11, 2022 at 02:17:43AM +0200, Yureka wrote: > From: Yureka Lilian <yuka@yuka.dev> > > This code is included in the build tools makemapdata and genmap, and it > expects that libc exposes a definition of u_char. But u_char is not > defined in either C or POSIX standards, and some systems don't have it. > Namely this breaks the build on hosts using musl libc, because musl only > exposes u_char if _GNU_SOURCE is defined. > > Signed-off-by: Yureka Lilian <yuka@yuka.dev> > --- > drivers/accessibility/speakup/utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h > index 4bf2ee8ac..4ce9a12f7 100644 > --- a/drivers/accessibility/speakup/utils.h > +++ b/drivers/accessibility/speakup/utils.h > @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info) > > static inline struct st_key *hash_name(char *name) > { > - u_char *pn = (u_char *)name; > + unsigned char *pn = (unsigned char *)name; > int hash = 0; > > while (*pn) { > -- > 2.37.3
This patch is corrupted and can not be applied. Please fix up and add the proper cc: stable tag when you resend it.
thanks,
greg k-h
| |