Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Fri, 14 Oct 2022 22:30:46 +0100 | Subject | Re: [PATCH v2 2/5] media: i2c: ov5645: Use runtime PM |
| |
Hi Sakari,
Thank you for the review.
On Fri, Oct 14, 2022 at 8:18 PM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Prabhakar, > > On Fri, Oct 14, 2022 at 07:34:56PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Switch to using runtime PM for power management. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > v1->v2 > > * Moved pm_runtime_*_autosuspend() calls after registering the subdev. > > --- <snip> > > @@ -795,7 +773,7 @@ static int ov5645_s_ctrl(struct v4l2_ctrl *ctrl) > > int ret; > > > > mutex_lock(&ov5645->power_lock); > > - if (!ov5645->power_count) { > > + if (!pm_runtime_get_if_in_use(ov5645->dev)) { > > mutex_unlock(&ov5645->power_lock); > > return 0; > > } > > @@ -827,6 +805,7 @@ static int ov5645_s_ctrl(struct v4l2_ctrl *ctrl) > > break; > > } > > > > + pm_runtime_put_autosuspend(ov5645->dev); > > I think you'll need pm_runtime_mark_last_busy() before this. I missed this > on the last round. Maybe in probe() too. Feel free to resend just this > patch. > Agreed, I'll respin this patch fixing the above.
Cheers, Prabhakar
| |