lkml.org 
[lkml]   [2022]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drm/amd/display: add a WARN() to irq service functions
Date
Currently, if we encounter unimplemented functions, it is difficult to
tell what caused them just by looking at dmesg and that is compounded by
the fact that it is often hard to reproduce said issues. So, to have
access to more detailed debugging information, add a WARN() to
dal_irq_service_ack() and dal_irq_service_set() that only triggers when
we encounter an unimplemented function.

Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
drivers/gpu/drm/amd/display/dc/irq/irq_service.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
index 7bad39bba86b..b895bdd8dc55 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
@@ -112,8 +112,11 @@ bool dal_irq_service_set(

dal_irq_service_ack(irq_service, source);

- if (info->funcs && info->funcs->set)
+ if (info->funcs && info->funcs->set) {
+ WARN(info->funcs->set == dal_irq_service_dummy_set,
+ "%s: src: %d, st: %d\n", __func__, source, enable);
return info->funcs->set(irq_service, info, enable);
+ }

dal_irq_service_set_generic(irq_service, info, enable);

@@ -146,8 +149,11 @@ bool dal_irq_service_ack(
return false;
}

- if (info->funcs && info->funcs->ack)
+ if (info->funcs && info->funcs->ack) {
+ WARN(info->funcs->ack == dal_irq_service_dummy_ack,
+ "%s: src: %d\n", __func__, source);
return info->funcs->ack(irq_service, info);
+ }

dal_irq_service_ack_generic(irq_service, info);

--
2.38.0
\
 
 \ /
  Last update: 2022-10-14 17:32    [W:0.086 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site