Messages in this thread | | | Date | Thu, 13 Oct 2022 23:33:47 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH] rtc: rtc-cmos: Fix event handler registration ordering issue |
| |
On Wed, 12 Oct 2022 20:07:01 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Because acpi_install_fixed_event_handler() enables the event > automatically on success, it is incorrect to call it before the > handler routine passed to it is ready to handle events. > > Unfortunately, the rtc-cmos driver does exactly the incorrect thing > by calling cmos_wake_setup(), which passes rtc_handler() to > acpi_install_fixed_event_handler(), before cmos_do_probe(), because > rtc_handler() uses dev_get_drvdata() to get to the cmos object > pointer and the driver data pointer is only populated in > cmos_do_probe(). > > [...]
Applied, thanks!
[1/1] rtc: rtc-cmos: Fix event handler registration ordering issue commit: 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
Best regards,
-- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |