lkml.org 
[lkml]   [2022]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] power: cpupower: utils: Optimize print_online_cpus and print_offline_cpus function
Date
1. Remove the initialization assignment of variables, and they will be
assigned first.
2. Remove the mandatory conversion of returned value of malloc function,
which returns void* type.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
tools/power/cpupower/utils/helpers/misc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/power/cpupower/utils/helpers/misc.c b/tools/power/cpupower/utils/helpers/misc.c
index 9547b29254a7..36dbd0562240 100644
--- a/tools/power/cpupower/utils/helpers/misc.c
+++ b/tools/power/cpupower/utils/helpers/misc.c
@@ -134,11 +134,11 @@ void get_cpustate(void)
*/
void print_online_cpus(void)
{
- int str_len = 0;
- char *online_cpus_str = NULL;
+ int str_len;
+ char *online_cpus_str;

str_len = online_cpus->size * 5;
- online_cpus_str = (void *)malloc(sizeof(char) * str_len);
+ online_cpus_str = malloc(sizeof(char) * str_len);

if (!bitmask_isallclear(online_cpus)) {
bitmask_displaylist(online_cpus_str, str_len, online_cpus);
@@ -152,11 +152,11 @@ void print_online_cpus(void)
*/
void print_offline_cpus(void)
{
- int str_len = 0;
- char *offline_cpus_str = NULL;
+ int str_len;
+ char *offline_cpus_str;

str_len = offline_cpus->size * 5;
- offline_cpus_str = (void *)malloc(sizeof(char) * str_len);
+ offline_cpus_str = malloc(sizeof(char) * str_len);

if (!bitmask_isallclear(offline_cpus)) {
bitmask_displaylist(offline_cpus_str, str_len, offline_cpus);
--
2.18.2
\
 
 \ /
  Last update: 2022-10-12 12:13    [W:0.088 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site