Messages in this thread | | | Date | Tue, 11 Oct 2022 15:51:06 -0400 | Subject | Re: [PATCH v1 2/5] dt-bindings: soc: hpe: Add hpe,gxp-plreg | From | Krzysztof Kozlowski <> |
| |
On 11/10/2022 14:55, nick.hawkins@hpe.com wrote: > From: Nick Hawkins <nick.hawkins@hpe.com> > > The hpe,gxp-plreg binding provides access to the board i/o through the > Programmable logic interface. The binding provides information to enable > use of the same driver across the HPE portfolio. > > Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com> > --- > .../bindings/soc/hpe/hpe,gxp-plreg.yaml | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/hpe/hpe,gxp-plreg.yaml > > diff --git a/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-plreg.yaml b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-plreg.yaml > new file mode 100644 > index 000000000000..cdc54e66d9a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-plreg.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/hpe/hpe,gxp-plreg.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
Drop quotes from both lines.
> + > +title: HPE GXP Programmable Logic Registers Controller > + > +maintainers: > + - Nick Hawkins <nick.hawkins@hpe.com> > + > +properties: > + compatible: > + items: > + - const: hpe,gxp-plreg > + - const: simple-mfd > + - const: syscon
Blank line
> + reg: > + maxItems: 1 > + > +required: > + - compatible > + > +additionalProperties: true
This must be false... and then you will see the errors to fix.
> + > +examples: > + - | > + cpld@1e789000 { > + compatible = "hpe,gxp-plreg", "simple-mfd", "syscon"; > + reg = <0x1e789000 0x1000>; > + fan1 {
fan (or fan-1)
> + bit = <0x01>; > + inst = <0x27>; > + id = <0x2B>; > + }; > + iopled1 {
led or led-1?
> + on = <0x04 0x01>; > + }; > + pwrbtn {
power-button?
> + latch = <0xFF 0xFF 0x04>;
Keep lower case hex everywhere.
> + }; > + }; > +
Best regards, Krzysztof
| |