lkml.org 
[lkml]   [2022]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 3/4] irqchip/meson-gpio: add select trigger type callback
On Sat, 08 Jan 2022 08:42:17 +0000,
Qianggui Song <qianggui.song@amlogic.com> wrote:
>
> Due to some chips may use different registers and offset, provide
> a set trigger type call back.
>
> Signed-off-by: Qianggui Song <qianggui.song@amlogic.com>
> ---
> drivers/irqchip/irq-meson-gpio.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-meson-gpio.c b/drivers/irqchip/irq-meson-gpio.c
> index 6a7b4fb13452..98419428fcbd 100644
> --- a/drivers/irqchip/irq-meson-gpio.c
> +++ b/drivers/irqchip/irq-meson-gpio.c
> @@ -55,6 +55,8 @@ struct irq_ctl_ops {
> void (*gpio_irq_sel_pin)(struct meson_gpio_irq_controller *ctl,
> unsigned int channel, unsigned long hwirq);
> void (*gpio_irq_init)(struct meson_gpio_irq_controller *ctl);
> + unsigned int (*gpio_irq_sel_type)(struct meson_gpio_irq_controller *ctl,
> + unsigned int idx, u32 val);
> };
>
> struct meson_gpio_irq_params {
> @@ -68,16 +70,17 @@ struct meson_gpio_irq_params {
> struct irq_ctl_ops ops;
> };
>
> -#define INIT_MESON_COMMON(irqs, init, sel) \
> +#define INIT_MESON_COMMON(irqs, init, sel, type) \
> .nr_hwirq = irqs, \
> .ops = { \
> .gpio_irq_init = init, \
> .gpio_irq_sel_pin = sel, \
> + .gpio_irq_sel_type = type, \
> },
>
> #define INIT_MESON8_COMMON_DATA(irqs) \
> INIT_MESON_COMMON(irqs, meson_gpio_irq_init_dummy, \
> - meson8_gpio_irq_sel_pin) \
> + meson8_gpio_irq_sel_pin, NULL) \
> .edge_single_offset = 0, \
> .pol_low_offset = 16, \
> .pin_sel_mask = 0xff, \
> @@ -85,7 +88,7 @@ struct meson_gpio_irq_params {
>
> #define INIT_MESON_A1_COMMON_DATA(irqs) \
> INIT_MESON_COMMON(irqs, meson_a1_gpio_irq_init, \
> - meson_a1_gpio_irq_sel_pin) \
> + meson_a1_gpio_irq_sel_pin, NULL) \
> .support_edge_both = true, \
> .edge_both_offset = 16, \
> .edge_single_offset = 8, \
> @@ -279,6 +282,10 @@ static int meson_gpio_irq_type_setup(struct meson_gpio_irq_controller *ctl,
> */
> type &= IRQ_TYPE_SENSE_MASK;
>
> + /* Some controllers may have different calculation method*/
> + if (params->ops.gpio_irq_sel_type)
> + return params->ops.gpio_irq_sel_type(ctl, idx, type);
> +

No. If you are going to indirect these things, indirect them for all
implementations and keep the code clean.

M.

--
Without deviation from the norm, progress is not possible.

\
 
 \ /
  Last update: 2022-01-08 11:45    [W:0.065 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site