Messages in this thread Patch in this message | | | From | Miaoqian Lin <> | Subject | [PATCH] softingcs: Fix memleak on registration failure in softingcs_probe | Date | Sat, 8 Jan 2022 09:25:51 +0000 |
| |
In case device registration fails during module initialisation, the platform device structure needs to be freed using platform_device_put() to properly free all resources (e.g. the device name).
Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/net/can/softing/softing_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c index 2e93ee792373..e5c939b63fa6 100644 --- a/drivers/net/can/softing/softing_cs.c +++ b/drivers/net/can/softing/softing_cs.c @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia) return 0; platform_failed: - kfree(dev); + platform_device_put(pdev); mem_failed: pcmcia_bad: pcmcia_failed: -- 2.17.1
| |