Messages in this thread | | | Date | Wed, 5 Jan 2022 11:28:38 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH v7] lib/crypto: blake2s: include as built-in |
| |
On Tue, Jan 04, 2022 at 06:02:52PM +0100, Ard Biesheuvel wrote: > > The only downside here is that the ARM/x86 accelerated shashes and the > generic shash now use the same core transform, right? Given that the > generic blake2s shash is never used for anything in the kernel, the > only reason for its existence was to be able to use the randomized > crypto testing infrastructure to test the arch code. > > Ergo, there is no point in retaining the blake2s shashes and we can > simply remove all of them. (Note that blake2b is used as an shash via > the crypto API by btrfs, but blake2s is only used via the library API)
I have no objections to removing blake2s.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |