Messages in this thread | | | Date | Tue, 4 Jan 2022 12:21:52 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH v7] lib/crypto: blake2s: include as built-in |
| |
On Mon, Jan 03, 2022 at 01:31:52PM +0100, Jason A. Donenfeld wrote: > In preparation for using blake2s in the RNG, we change the way that it > is wired-in to the build system. Instead of using ifdefs to select the > right symbol, we use weak symbols. And because ARM doesn't need the > generic implementation, we make the generic one default only if an arch > library doesn't need it already, and then have arch libraries that do > need it opt-in. So that the arch libraries can remain tristate rather > than bool, we then split the shash part from the glue code. > > Acked-by: Ard Biesheuvel <ardb@kernel.org> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: linux-kbuild@vger.kernel.org > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> > --- > Herbert - As discussed, I still intend to take this via the > crng/random.git tree because it forms a dependency, and I'd like to send > a pull very early in the 5.17 cycle. I've taken some care to minimize > changes to the {arch/*/}crypto/Kconfig files, as you mentioned this > might cause some conflicts. Your tree should work cleanly on top of this > commit.
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
> Changes v6->v7: > - Split arch shash implementations out from the glue code, so that they > can remain as tristates, and we thus don't need to touch > arch/*/crypto/Kconfig at all.
This looks good to me although I confess that I haven't actually tried to build it :) Hopefully the build robots will take care of this.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |