lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5] Fix fill_files_note
On Mon, Jan 31, 2022 at 12:44:53PM -0600, Eric W. Biederman wrote:
>
> Matthew Wilcox has reported that a missing mmap_lock in file_files_note,
> which could cause trouble.
>
> Refactor the code and clean it up so that the vma snapshot makes
> it to fill_files_note, and then use the vma snapshot in fill_files_note.
>
> Folks please review this as this looks correct to me but I haven't done
> anything beyond compile testing this yet.
>
> Eric W. Biederman (5):
> coredump: Move definition of struct coredump_params into coredump.h
> coredump: Snapshot the vmas in do_coredump
> coredump: Remove the WARN_ON in dump_vma_snapshot
> coredump/elf: Pass coredump_params into fill_note_info
> coredump: Use the vma snapshot in fill_files_note
>
> fs/binfmt_elf.c | 61 ++++++++++++++++++++++--------------------------
> fs/binfmt_elf_fdpic.c | 18 +++++---------
> fs/coredump.c | 55 +++++++++++++++++++++++++++++--------------
> include/linux/binfmts.h | 13 +----------
> include/linux/coredump.h | 20 ++++++++++++----
> 5 files changed, 88 insertions(+), 79 deletions(-)
>
>
> Eric

This looks like a good clean-up to me. For the series:

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook

\
 
 \ /
  Last update: 2022-01-31 21:58    [W:0.125 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site