lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 1/5] coredump: Move definition of struct coredump_params into coredump.h

    Move the definition of struct coredump_params into coredump.h where
    it belongs.

    Remove the slightly errorneous comment explaining why struct
    coredump_params was declared in binfmts.h.

    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    ---
    include/linux/binfmts.h | 13 +------------
    include/linux/coredump.h | 12 +++++++++++-
    2 files changed, 12 insertions(+), 13 deletions(-)

    diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
    index 049cf9421d83..05a91f5499ba 100644
    --- a/include/linux/binfmts.h
    +++ b/include/linux/binfmts.h
    @@ -8,6 +8,7 @@
    #include <uapi/linux/binfmts.h>

    struct filename;
    +struct coredump_params;

    #define CORENAME_MAX_SIZE 128

    @@ -77,18 +78,6 @@ struct linux_binprm {
    #define BINPRM_FLAGS_PRESERVE_ARGV0_BIT 3
    #define BINPRM_FLAGS_PRESERVE_ARGV0 (1 << BINPRM_FLAGS_PRESERVE_ARGV0_BIT)

    -/* Function parameter for binfmt->coredump */
    -struct coredump_params {
    - const kernel_siginfo_t *siginfo;
    - struct pt_regs *regs;
    - struct file *file;
    - unsigned long limit;
    - unsigned long mm_flags;
    - loff_t written;
    - loff_t pos;
    - loff_t to_skip;
    -};
    -
    /*
    * This structure defines the functions that are used to load the binary formats that
    * linux accepts.
    diff --git a/include/linux/coredump.h b/include/linux/coredump.h
    index 248a68c668b4..2ee1460a1d66 100644
    --- a/include/linux/coredump.h
    +++ b/include/linux/coredump.h
    @@ -14,11 +14,21 @@ struct core_vma_metadata {
    unsigned long dump_size;
    };

    +struct coredump_params {
    + const kernel_siginfo_t *siginfo;
    + struct pt_regs *regs;
    + struct file *file;
    + unsigned long limit;
    + unsigned long mm_flags;
    + loff_t written;
    + loff_t pos;
    + loff_t to_skip;
    +};
    +
    /*
    * These are the only things you should do on a core-file: use only these
    * functions to write out all the necessary info.
    */
    -struct coredump_params;
    extern void dump_skip_to(struct coredump_params *cprm, unsigned long to);
    extern void dump_skip(struct coredump_params *cprm, size_t nr);
    extern int dump_emit(struct coredump_params *cprm, const void *addr, int nr);
    --
    2.29.2
    \
     
     \ /
      Last update: 2022-01-31 19:47    [W:4.032 / U:1.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site