lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to externally register phy reset control
Date
On Sat, Jan 29, 2022 at 02:02:16PM -0800, Colin Foster wrote:
> @@ -257,15 +260,14 @@ static int mscc_miim_probe(struct platform_device *pdev)
> }
> }
>
> - ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);
> + ret = mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0,
> + phy_regmap, 0);
> if (ret < 0) {
> dev_err(dev, "Unable to setup the MDIO bus\n");
> return ret;
> }
>
> miim = bus->priv;

You left this variable set but not used. Please delete it.

> - miim->phy_regs = phy_regmap;
> - miim->phy_reset_offset = 0;
>
> ret = of_mdiobus_register(bus, dev->of_node);
> if (ret < 0) {
\
 
 \ /
  Last update: 2022-01-31 18:13    [W:0.258 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site