lkml.org 
[lkml]   [2022]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC v6 net-next 8/9] net: dsa: felix: add configurable device quirks
    Date
    On Sat, Jan 29, 2022 at 02:02:20PM -0800, Colin Foster wrote:
    > The define FELIX_MAC_QUIRKS was used directly in the felix.c shared driver.
    > Other devices (VSC7512 for example) don't require the same quirks, so they
    > need to be configured on a per-device basis.
    >
    > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
    > ---

    Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

    Just one small comment.

    > diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/felix.h
    > index 9395ac119d33..f35894b06ce5 100644
    > --- a/drivers/net/dsa/ocelot/felix.h
    > +++ b/drivers/net/dsa/ocelot/felix.h
    > @@ -26,6 +26,7 @@ struct felix_info {
    > u16 vcap_pol_base2;
    > u16 vcap_pol_max2;
    > const struct ptp_clock_info *ptp_caps;
    > + u32 quirks;

    It's an "unsigned long" when passed to ocelot_phylink_mac_link_{up,down},
    so please keep it the same here.
    \
     
     \ /
      Last update: 2022-01-31 19:16    [W:4.131 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site