| From | Chaitanya Kulkarni <> | Subject | Re: [PATCH v5 12/24] nvme-pci: convert to using dma_map_sgtable() | Date | Fri, 28 Jan 2022 09:13:11 +0000 |
| |
On 1/27/22 4:26 PM, Logan Gunthorpe wrote: > External email: Use caution opening links or attachments > > > The dma_map operations now support P2PDMA pages directly. So remove > the calls to pci_p2pdma_[un]map_sg_attrs() and replace them with calls > to dma_map_sgtable(). > > dma_map_sgtable() returns more complete error codes than dma_map_sg() > and allows differentiating EREMOTEIO errors in case an unsupported > P2PDMA transfer is requested. When this happens, return BLK_STS_TARGET > so the request isn't retried. > > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com> > ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
|