lkml.org 
[lkml]   [2022]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v5 04/24] PCI/P2PDMA: Attempt to set map_type if it has not been set
    Attempt to find the mapping type for P2PDMA pages on the first
    DMA map attempt if it has not been done ahead of time.

    Previously, the mapping type was expected to be calculated ahead of
    time, but if pages are to come from userspace then there's no
    way to ensure the path was checked ahead of time.

    This change will calculate the mapping type if it hasn't pre-calculated
    so it is no longer invalid to call pci_p2pdma_map_sg() before the mapping
    type is calculated, so drop the WARN_ON when that is he case.

    Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
    Acked-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
    ---
    drivers/pci/p2pdma.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
    index 1015274bd2fe..bb8900ce073a 100644
    --- a/drivers/pci/p2pdma.c
    +++ b/drivers/pci/p2pdma.c
    @@ -848,6 +848,7 @@ static enum pci_p2pdma_map_type pci_p2pdma_map_type(struct dev_pagemap *pgmap,
    struct pci_dev *provider = to_p2p_pgmap(pgmap)->provider;
    struct pci_dev *client;
    struct pci_p2pdma *p2pdma;
    + int dist;

    if (!provider->p2pdma)
    return PCI_P2PDMA_MAP_NOT_SUPPORTED;
    @@ -864,6 +865,10 @@ static enum pci_p2pdma_map_type pci_p2pdma_map_type(struct dev_pagemap *pgmap,
    type = xa_to_value(xa_load(&p2pdma->map_types,
    map_types_idx(client)));
    rcu_read_unlock();
    +
    + if (type == PCI_P2PDMA_MAP_UNKNOWN)
    + return calc_map_type_and_dist(provider, client, &dist, true);
    +
    return type;
    }

    @@ -906,7 +911,7 @@ int pci_p2pdma_map_sg_attrs(struct device *dev, struct scatterlist *sg,
    case PCI_P2PDMA_MAP_BUS_ADDR:
    return __pci_p2pdma_map_sg(p2p_pgmap, dev, sg, nents);
    default:
    - WARN_ON_ONCE(1);
    + /* Mapping is not Supported */
    return 0;
    }
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-01-28 01:27    [W:4.563 / U:1.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site