Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 04/11] tty: tty_port_open, document shutdown vs failed activate | Date | Mon, 24 Jan 2022 08:14:23 +0100 |
| |
Add a note that ->shutdown is not called when ->activate fails. Just so we are clear.
Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/tty/tty_port.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 7644834640f1..4282895ede9e 100644 --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -736,6 +736,9 @@ EXPORT_SYMBOL_GPL(tty_port_install); * the device to be ready using tty_port_block_til_ready() (e.g. raises * DTR/CTS and waits for carrier). * + * Note that @port->ops->shutdown is not called when @port->ops->activate + * returns an error (on the contrary, @tty->ops->close is). + * * Locking: Caller holds tty lock. * * Note: may drop and reacquire tty lock (in tty_port_block_til_ready()) so -- 2.34.1
| |