Messages in this thread | | | Date | Mon, 24 Jan 2022 10:06:19 +0100 | From | Richard Genoud <> | Subject | Re: [PATCH 10/11] serial: make uart_console_write->putchar()'s character a char |
| |
Le 24/01/2022 à 08:14, Jiri Slaby a écrit : > Currently, uart_console_write->putchar's second parameter (the > character) is of type int. It makes little sense, provided uart_console_write() > accepts the input string as "const char *s" and passes its content -- the > characters -- to putchar(). So switch the character's type also to char. > > This makes the types consistent. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Paul Cercueil <paul@crapouillou.net> > Cc: Tobias Klauser <tklauser@distanz.ch> > Cc: Russell King <linux@armlinux.org.uk> > Cc: Vineet Gupta <vgupta@kernel.org> > Cc: Richard Genoud <richard.genoud@gmail.com> > Cc: Nicolas Ferre <nicolas.ferre@microchip.com> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Ludovic Desroches <ludovic.desroches@microchip.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Alexander Shiyan <shc_work@mail.ru> > Cc: Baruch Siach <baruch@tkos.co.il> > Cc: "Maciej W. Rozycki" <macro@orcam.me.uk> > Cc: Paul Walmsley <paul.walmsley@sifive.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Albert Ou <aou@eecs.berkeley.edu> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Cc: Karol Gugala <kgugala@antmicro.com> > Cc: Mateusz Holenko <mholenko@antmicro.com> > Cc: Vladimir Zapolskiy <vz@mleia.com> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Jerome Brunet <jbrunet@baylibre.com> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: Taichi Sugaya <sugaya.taichi@socionext.com> > Cc: Takao Orito <orito.takao@socionext.com> > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Sudeep Holla <sudeep.holla@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: "Andreas Färber" <afaerber@suse.de> > Cc: Manivannan Sadhasivam <mani@kernel.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Cc: Orson Zhai <orsonzhai@gmail.com> > Cc: Baolin Wang <baolin.wang7@gmail.com> > Cc: Chunyan Zhang <zhang.lyra@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Peter Korsgaard <jacmet@sunsite.dk> > Cc: Michal Simek <michal.simek@xilinx.com> For drivers/tty/serial/atmel_serial.c: Acked-by: Richard Genoud <richard.genoud@gmail.com>
> --- > drivers/tty/goldfish.c | 2 +- > drivers/tty/hvc/hvc_dcc.c | 2 +- > drivers/tty/serial/21285.c | 2 +- > drivers/tty/serial/8250/8250_early.c | 2 +- > drivers/tty/serial/8250/8250_ingenic.c | 2 +- > drivers/tty/serial/8250/8250_port.c | 2 +- > drivers/tty/serial/altera_jtaguart.c | 4 ++-- > drivers/tty/serial/altera_uart.c | 2 +- > drivers/tty/serial/amba-pl010.c | 2 +- > drivers/tty/serial/amba-pl011.c | 6 +++--- > drivers/tty/serial/apbuart.c | 2 +- > drivers/tty/serial/ar933x_uart.c | 2 +- > drivers/tty/serial/arc_uart.c | 2 +- > drivers/tty/serial/atmel_serial.c | 2 +- > drivers/tty/serial/bcm63xx_uart.c | 2 +- > drivers/tty/serial/clps711x.c | 2 +- > drivers/tty/serial/digicolor-usart.c | 2 +- > drivers/tty/serial/dz.c | 2 +- > drivers/tty/serial/earlycon-arm-semihost.c | 2 +- > drivers/tty/serial/earlycon-riscv-sbi.c | 2 +- > drivers/tty/serial/fsl_linflexuart.c | 4 ++-- > drivers/tty/serial/fsl_lpuart.c | 4 ++-- > drivers/tty/serial/imx.c | 2 +- > drivers/tty/serial/imx_earlycon.c | 2 +- > drivers/tty/serial/ip22zilog.c | 2 +- > drivers/tty/serial/lantiq.c | 2 +- > drivers/tty/serial/liteuart.c | 2 +- > drivers/tty/serial/lpc32xx_hs.c | 2 +- > drivers/tty/serial/meson_uart.c | 2 +- > drivers/tty/serial/milbeaut_usio.c | 2 +- > drivers/tty/serial/mps2-uart.c | 4 ++-- > drivers/tty/serial/mvebu-uart.c | 4 ++-- > drivers/tty/serial/mxs-auart.c | 2 +- > drivers/tty/serial/omap-serial.c | 2 +- > drivers/tty/serial/owl-uart.c | 2 +- > drivers/tty/serial/pch_uart.c | 2 +- > drivers/tty/serial/pic32_uart.c | 2 +- > drivers/tty/serial/pmac_zilog.c | 2 +- > drivers/tty/serial/pxa.c | 2 +- > drivers/tty/serial/qcom_geni_serial.c | 2 +- > drivers/tty/serial/rda-uart.c | 2 +- > drivers/tty/serial/sa1100.c | 2 +- > drivers/tty/serial/samsung_tty.c | 4 ++-- > drivers/tty/serial/sb1250-duart.c | 2 +- > drivers/tty/serial/sccnxp.c | 2 +- > drivers/tty/serial/serial_core.c | 2 +- > drivers/tty/serial/serial_txx9.c | 2 +- > drivers/tty/serial/sh-sci.c | 2 +- > drivers/tty/serial/sifive.c | 4 ++-- > drivers/tty/serial/sprd_serial.c | 2 +- > drivers/tty/serial/st-asc.c | 2 +- > drivers/tty/serial/stm32-usart.c | 2 +- > drivers/tty/serial/sunsu.c | 2 +- > drivers/tty/serial/sunzilog.c | 4 ++-- > drivers/tty/serial/uartlite.c | 4 ++-- > drivers/tty/serial/vr41xx_siu.c | 2 +- > drivers/tty/serial/vt8500_serial.c | 2 +- > drivers/tty/serial/xilinx_uartps.c | 2 +- > drivers/tty/serial/zs.c | 2 +- > include/linux/serial_core.h | 2 +- > 60 files changed, 71 insertions(+), 71 deletions(-) > Thanks!
| |