Messages in this thread | | | Subject | Re: [PATCH V3 4/4] mmc: cqhci: Capture eMMC and SD card errors | From | Adrian Hunter <> | Date | Fri, 21 Jan 2022 10:22:29 +0200 |
| |
On 20/01/2022 19:26, Shaik Sajida Bhanu wrote: > Add changes to capture eMMC and SD card errors. > This is useful for debug and testing. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> > Signed-off-by: Liangliang Lu <luliang@codeaurora.org> > Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org> > Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org> > Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com> > --- > drivers/mmc/host/cqhci-core.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c > index b0d30c3..2908d30 100644 > --- a/drivers/mmc/host/cqhci-core.c > +++ b/drivers/mmc/host/cqhci-core.c > @@ -822,8 +822,15 @@ irqreturn_t cqhci_irq(struct mmc_host *mmc, u32 intmask, int cmd_error, > pr_debug("%s: cqhci: IRQ status: 0x%08x\n", mmc_hostname(mmc), status); > > if ((status & (CQHCI_IS_RED | CQHCI_IS_GCE | CQHCI_IS_ICCE)) || > - cmd_error || data_error) > + cmd_error || data_error) { > + if ((status & CQHCI_IS_RED) && mmc->err_stats_enabled) > + mmc_debugfs_err_stats_inc(mmc, MMC_ERR_CMDQ_RED); > + if ((status & CQHCI_IS_GCE) && (mmc->err_stats_enabled)) > + mmc_debugfs_err_stats_inc(mmc, MMC_ERR_CMDQ_GCE); > + if ((status & CQHCI_IS_ICCE) && mmc->err_stats_enabled) > + mmc_debugfs_err_stats_inc(mmc, MMC_ERR_CMDQ_ICCE);
Please don't check mmc->err_stats_enabled
> cqhci_error_irq(mmc, status, cmd_error, data_error); > + } > > if (status & CQHCI_IS_TCC) { > /* read TCN and complete the request */ >
| |