Messages in this thread | | | Subject | Re: [PATCH V3 3/4] mmc: core: Capture eMMC and SD card errors | From | Adrian Hunter <> | Date | Fri, 21 Jan 2022 10:20:09 +0200 |
| |
On 20/01/2022 19:26, Shaik Sajida Bhanu wrote: > Add changes to capture eMMC and SD card errors. > This is useful for debug and testing. > > Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> > Signed-off-by: Liangliang Lu <luliang@codeaurora.org> > Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org> > Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org> > Signed-off-by: Ram Prakash Gupta <quic_rampraka@quicinc.com> > --- > drivers/mmc/core/core.c | 8 ++++++++ > drivers/mmc/core/queue.c | 3 +++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index 368f104..c586d69 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -2242,6 +2242,14 @@ void mmc_rescan(struct work_struct *work) > if (freqs[i] <= host->f_min) > break; > } > + > + /* > + * Ignore the command timeout errors observed during > + * the card init as those are excepted. > + */ > +
Please remove blank line here.
> + if (host && host->err_stats_enabled)
The condition is not needed.
> + host->err_stats[MMC_ERR_CMD_TIMEOUT] = 0;
Please put this after successful call to mmc_rescan_try_freq
> mmc_release_host(host); > > out: > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index c69b2d9..7dc9dfb 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -100,6 +100,9 @@ static enum blk_eh_timer_return mmc_cqe_timed_out(struct request *req) > enum mmc_issue_type issue_type = mmc_issue_type(mq, req); > bool recovery_needed = false; > > + if (host->err_stats_enabled) > + mmc_debugfs_err_stats_inc(host, MMC_ERR_CMDQ_REQ_TIMEOUT);
Doesn't this get covered by the drivers. It seems like this should not be needed.
> + > switch (issue_type) { > case MMC_ISSUE_ASYNC: > case MMC_ISSUE_DCMD: >
| |