Messages in this thread | | | Subject | Re: [PATCH 1/3] arm64: dts: meson: add Broadcom WiFi to P212 dtsi | From | Neil Armstrong <> | Date | Mon, 17 Jan 2022 15:32:04 +0100 |
| |
On 13/01/2022 05:17, Christian Hewitt wrote: > The P212 has a combined WiFi/BT module. The BT side is already enabled > in the dtsi but the WiFi side is not. Let's tweak SDIO speed (in-line > with other GXL/GXM devices) and enable the WiFi module. > > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi > index 05cb2f5e5c36..c635e5858929 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtsi > @@ -113,7 +113,7 @@ > > bus-width = <4>; > cap-sd-highspeed; > - max-frequency = <50000000>; > + max-frequency = <100000000>; > > non-removable; > disable-wp; > @@ -125,6 +125,11 @@ > > vmmc-supply = <&vddao_3v3>; > vqmmc-supply = <&vddio_boot>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > }; > > /* SD card */ >
As I commented in patch 3, the 2 changes should be split.
When you resend, you can put my:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
in both patches.
Neil
| |