Messages in this thread Patch in this message | | | From | trix@redhat ... | Subject | [PATCH] ath11k: fix error handling in ath11k_qmi_assign_target_mem_chunk() | Date | Sun, 16 Jan 2022 06:42:06 -0800 |
| |
From: Tom Rix <trix@redhat.com>
Clang static analysis reports this problem qmi.c:1935:5: warning: Undefined or garbage value returned to caller return ret; ^~~~~~~~~~
ret is uninitialized. When of_parse_phandle() fails, garbage is returned. So return -EINVAL.
Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices") Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/wireless/ath/ath11k/qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c index 65d3c6ba35ae6..81b2304b1fdeb 100644 --- a/drivers/net/wireless/ath/ath11k/qmi.c +++ b/drivers/net/wireless/ath/ath11k/qmi.c @@ -1932,7 +1932,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab) if (!hremote_node) { ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi fail to get hremote_node\n"); - return ret; + return -EINVAL; } ret = of_address_to_resource(hremote_node, 0, &res); -- 2.26.3
| |