lkml.org 
[lkml]   [2021]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[BUG] android: possible ABBA deadlock in print_binder_proc() and binder_get_txn_from_and_acq_inner()
Date
Hello,

My static analysis tool reports a possible ABBA deadlock in the android
driver in Linux 5.10:

print_binder_proc()
  binder_inner_proc_lock()
    _binder_inner_proc_lock()
      spin_lock(&proc->inner_lock); --> Line 662 (Lock A)
  print_binder_thread_ilocked()
    print_binder_transaction_ilocked()
      spin_lock(&t->lock); --> Line 5531 (Lock B)

binder_get_txn_from_and_acq_inner()
  binder_get_txn_from()
    spin_lock(&t->lock); --> Line 1833 (Lock B)
  binder_inner_proc_lock()
    _binder_inner_proc_lock()
      spin_lock(&proc->inner_lock); --> Line 662 (Lock A)

When print_binder_proc() and binder_get_txn_from_and_acq_inner() are
concurrently executed, the deadlock can occur.

I am not quite sure whether this possible deadlock is real and how to
fix it if it is real.
Any feedback would be appreciated, thanks :)

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>


Best wishes,
Jia-Ju Bai

\
 
 \ /
  Last update: 2021-09-07 04:30    [W:0.052 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site