Messages in this thread Patch in this message | | | From | Dongliang Mu <> | Subject | [PATCH] nilfs2: fix memory leak in nilfs_sysfs_create_device_group | Date | Mon, 6 Sep 2021 12:13:30 +0800 |
| |
The commit 8fd0c1b0647a ("nilfs2: fix memory leak in nilfs_sysfs_delete_device_group") adds a kobject_put to free the leaking object name. However, it is incomplete to only add kobject_put in the nilfs_sysfs_delete_device_group. The function nilfs_sysfs_create_device_group also needs the kobject_put to free the object name in the error handling part.
Fix this by adding kobject_put in the error handling code of nilfs_sysfs_create_device_group.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> --- fs/nilfs2/sysfs.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 68e8d61e28dd..7ab60711ca76 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -1024,6 +1024,7 @@ int nilfs_sysfs_create_device_group(struct super_block *sb) cleanup_dev_kobject: kobject_del(&nilfs->ns_dev_kobj); + kobject_put(&nilfs->ns_dev_kobj); free_dev_subgroups: kfree(nilfs->ns_dev_subgroups); -- 2.25.1
| |