Messages in this thread | | | Date | Sun, 26 Sep 2021 15:59:18 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 1/4] net: bcmgenet: remove netif_carrier_off from adjust_link |
| |
On Sat, Sep 25, 2021 at 08:21:11PM -0700, Florian Fainelli wrote: > From: Doug Berger <opendmb@gmail.com> > > The bcmgenet_mii_setup() function is registered as the adjust_link > callback from the phylib for the GENET driver. > > The phylib always sets the netif_carrier according to phydev->link > prior to invoking the adjust_link callback, so there is no need to > repeat that in the link down case within the network driver. > > Signed-off-by: Doug Berger <opendmb@gmail.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |