Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 25 Sep 2021 11:47:08 -0700 | Subject | Re: [PATCH] Urgent bug fix causing Apple SSDs to not work. |
| |
On Fri, Sep 24, 2021 at 9:02 PM Aditya Garg <gargaditya08@live.com> wrote: > > From: Aditya Garg <gargaditya08@live.com> > Date: Fri, 24 Sep 2021 15:36:45 +0530 > Subject: [PATCH] Revert nvme to 5.14.5 to fix incompatibility arised in Apple SSDs. > Fixes: e7006de6c238 (nvme: code command_id with a genctr for use-after-free validation)
I think we need to hear more about the problem than just revert a commit like this randomly. That commit has already been picked up for -stable,
What are the exact symptoms, and which Apple SSD is this?
I do find this:
https://lore.kernel.org/all/cjJiSFV77WM51ciS8EuBcdeBcv9T83PUB-Kw3yi8PuC_LwrrUUnQ3w5RC1PbKvSYE72KryXp3wOJhv4Ov_WWIe2gKWOOo5uwuUjbbFA8HDM=@protonmail.com/
which instead of a revert has an actual patch. Can you try that one?
Keith Busch replied to that one, saying that the Apple SSD might not be spec compliant, but hey, what else is new? If we start demanding that hardware comply with specs, we'd have to scrap the whole notion of working in the real world. Plus it would be very hypocritical of us, since we ignore all specs when we deem them too limiting (whether they be language specs, POSIX OS specs, or whatever).
Linus
| |