lkml.org 
[lkml]   [2021]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] clocksource: arc_timer: eliminate redefined macro error
From
Date
On 9/23/21 2:42 AM, Shahab Vahedi wrote:
> Hi Randy,
>
> I have one minor comment.
>
> On 9/23/21 5:18 AM, Randy Dunlap wrote:
>>
>> --- linux-next-20210917.orig/include/soc/arc/timers.h
>> +++ linux-next-20210917/include/soc/arc/timers.h
>> @@ -17,7 +17,7 @@
>> #define ARC_REG_TIMER1_CNT 0x100 /* timer 1 count */
>>
>> /* CTRL reg bits */
>> -#define TIMER_CTRL_IE (1 << 0) /* Interrupt when Count reaches limit */
>> +#define TIMER_CTRL_IEN (1 << 0) /* Interrupt when Count reaches limit */
>
> Could you change the name to "ARC_TIMER_CTRL_IE" instead? and while at it, please rename
> "TIMER_CTRL_NH" to "ARC_TIMER_CTRL_NH" for obvious consistency reasons and saving us
> from future clashes. Thank you!
>

OK, no problem.

Thanks for the feedback.

--
~Randy

\
 
 \ /
  Last update: 2021-09-23 17:29    [W:0.205 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site