Messages in this thread | | | From | Shahab Vahedi <> | Subject | Re: [PATCH] clocksource: arc_timer: eliminate redefined macro error | Date | Thu, 23 Sep 2021 09:42:10 +0000 |
| |
Hi Randy,
I have one minor comment.
On 9/23/21 5:18 AM, Randy Dunlap wrote: > > --- linux-next-20210917.orig/include/soc/arc/timers.h > +++ linux-next-20210917/include/soc/arc/timers.h > @@ -17,7 +17,7 @@ > #define ARC_REG_TIMER1_CNT 0x100 /* timer 1 count */ > > /* CTRL reg bits */ > -#define TIMER_CTRL_IE (1 << 0) /* Interrupt when Count reaches limit */ > +#define TIMER_CTRL_IEN (1 << 0) /* Interrupt when Count reaches limit */
Could you change the name to "ARC_TIMER_CTRL_IE" instead? and while at it, please rename "TIMER_CTRL_NH" to "ARC_TIMER_CTRL_NH" for obvious consistency reasons and saving us from future clashes. Thank you!
-- Shahab
| |