lkml.org 
[lkml]   [2021]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC
Hi Cai,

On Tue, Sep 21, 2021 at 2:29 AM Cai Huoqing <caihuoqing@baidu.com> wrote:

> +error_iio_device_register:
> + clk_disable_unprepare(adc->ipg_clk);
> +error_adc_ipg_clk_enable:
> + clk_disable_unprepare(adc->clk);
> +error_adc_clk_enable:
> + regulator_disable(adc->vref);

Please rename these labels to indicate the action that will be performed.

Something like this:

error_ipg_clk_disable:
clk_disable_unprepare(adc->ipg_clk);
error_adc_clk_disable:
clk_disable_unprepare(adc->clk);
error_regulator_disable:
regulator_disable(adc->vref);

\
 
 \ /
  Last update: 2021-09-24 00:13    [W:0.064 / U:1.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site