Messages in this thread | | | Date | Fri, 17 Sep 2021 08:48:29 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v1 1/6] gcc-plugins/structleak: add makefile var for disabling structleak |
| |
On Thu, Sep 16, 2021 at 11:10:59PM -0700, Brendan Higgins wrote: > KUnit and structleak don't play nice, so add a makefile variable for > enabling structleak when it complains. > > Co-developed-by: Kees Cook <keescook@chromium.org>
For a C-d-b, also include a S-o-b:
Signed-off-by: Kees Cook <keescook@chromium.org>
But otherwise, yes, this is good. :)
-Kees
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > --- > scripts/Makefile.gcc-plugins | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/scripts/Makefile.gcc-plugins b/scripts/Makefile.gcc-plugins > index 952e46876329a..4aad284800355 100644 > --- a/scripts/Makefile.gcc-plugins > +++ b/scripts/Makefile.gcc-plugins > @@ -19,6 +19,10 @@ gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF) \ > += -fplugin-arg-structleak_plugin-byref > gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL) \ > += -fplugin-arg-structleak_plugin-byref-all > +ifdef CONFIG_GCC_PLUGIN_STRUCTLEAK > + DISABLE_STRUCTLEAK_PLUGIN += -fplugin-arg-structleak_plugin-disable > +endif > +export DISABLE_STRUCTLEAK_PLUGIN > gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK) \ > += -DSTRUCTLEAK_PLUGIN > > -- > 2.33.0.464.g1972c5931b-goog >
-- Kees Cook
| |