Messages in this thread | | | From | Brendan Higgins <> | Date | Wed, 29 Sep 2021 13:59:09 -0700 | Subject | Re: [PATCH v1 5/6] mmc: sdhci-of-aspeed: build kunit tests without structleak plugin |
| |
On Fri, Sep 17, 2021 at 11:40 AM Linus Torvalds <torvalds@linux-foundation.org> wrote: > > On Fri, Sep 17, 2021 at 8:57 AM Kees Cook <keescook@chromium.org> wrote: > > > > This isn't a stand-alone test object, so I'm less excited about > > disabling STRUCTLEAK here. > > Yeah, please don't do this for things that aren't pure tests. You're > now disabling security measures (even if I hate the gcc plugins and > hope they will go away).
Oh, whoops, yeah, I shouldn't do that. I am just going to drop this patch entirely, as I wasn't able to reproduce the stack frame size issue on qemu anyway (as I mentioned on the cover letter).
Thanks for catching this.
Sorry!
| |