Messages in this thread | | | Date | Fri, 10 Sep 2021 09:30:11 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v4 02/18] KVM: arm64: selftests: Add sysreg.h |
| |
On Thu, Sep 09, 2021 at 01:06:31PM -0700, Raghavendra Rao Ananta wrote: > On Thu, Sep 9, 2021 at 10:18 AM Mark Brown <broonie@kernel.org> wrote:
> > > create mode 100644 tools/testing/selftests/kvm/include/aarch64/sysreg.h
> > Can we arrange to copy this at build time rather than having a duplicate > > copy we need to keep in sync? We have some stuff to do this for uapi > > headers already.
> That's a great idea actually (I wasn't aware of it). But, probably > should've mentioned it earlier, I had a hard time compiling the header > as is so I modified it a little bit and made the definitions of > [write|read]_sysreg_s() similar to the ones in kvm-unit-tests. > I'll try my best to get the original format working and try to > implement your idea if it works.
One option would be to do something like split out the bits that can be shared into a separate header which can be included from both places and then have the header with the unsharable bits include that. Something like sysreg.h and sysreg_defs.h for example. [unhandled content-type:application/pgp-signature] | |