Messages in this thread | | | From | Raghavendra Rao Ananta <> | Date | Thu, 9 Sep 2021 13:06:31 -0700 | Subject | Re: [PATCH v4 02/18] KVM: arm64: selftests: Add sysreg.h |
| |
On Thu, Sep 9, 2021 at 10:18 AM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Sep 09, 2021 at 01:38:02AM +0000, Raghavendra Rao Ananta wrote: > > Bring-in the kernel's arch/arm64/include/asm/sysreg.h > > into selftests to make use of all the standard > > register definitions in consistence with the kernel. > > > Signed-off-by: Raghavendra Rao Ananta <rananta@google.com> > > --- > > .../selftests/kvm/include/aarch64/sysreg.h | 1278 +++++++++++++++++ > > 1 file changed, 1278 insertions(+) > > create mode 100644 tools/testing/selftests/kvm/include/aarch64/sysreg.h > > Can we arrange to copy this at build time rather than having a duplicate > copy we need to keep in sync? We have some stuff to do this for uapi > headers already.
That's a great idea actually (I wasn't aware of it). But, probably should've mentioned it earlier, I had a hard time compiling the header as is so I modified it a little bit and made the definitions of [write|read]_sysreg_s() similar to the ones in kvm-unit-tests. I'll try my best to get the original format working and try to implement your idea if it works.
Regards, Raghavendra
| |