Messages in this thread | | | Date | Sat, 7 Aug 2021 16:30:25 +0800 | From | kernel test robot <> | Subject | [djwong-xfs:xfs-5.15-merge 10/25] fs/xfs/xfs_super.c:767 xfs_fs_sync_fs() warn: inconsistent indenting |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git xfs-5.15-merge head: eabe005e2fe7a139233e5e0b7b125042a1b45c8f commit: 6df693ed7ba9ec03cafc38d5064de376a11243e2 [10/25] xfs: per-cpu deferred inode inactivation queues config: x86_64-randconfig-m001-20210804 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
smatch warnings: fs/xfs/xfs_super.c:767 xfs_fs_sync_fs() warn: inconsistent indenting
vim +767 fs/xfs/xfs_super.c
728 729 STATIC int 730 xfs_fs_sync_fs( 731 struct super_block *sb, 732 int wait) 733 { 734 struct xfs_mount *mp = XFS_M(sb); 735 736 trace_xfs_fs_sync_fs(mp, __return_address); 737 738 /* 739 * Doing anything during the async pass would be counterproductive. 740 */ 741 if (!wait) 742 return 0; 743 744 xfs_log_force(mp, XFS_LOG_SYNC); 745 if (laptop_mode) { 746 /* 747 * The disk must be active because we're syncing. 748 * We schedule log work now (now that the disk is 749 * active) instead of later (when it might not be). 750 */ 751 flush_delayed_work(&mp->m_log->l_work); 752 } 753 754 /* 755 * If we are called with page faults frozen out, it means we are about 756 * to freeze the transaction subsystem. Take the opportunity to shut 757 * down inodegc because once SB_FREEZE_FS is set it's too late to 758 * prevent inactivation races with freeze. The fs doesn't get called 759 * again by the freezing process until after SB_FREEZE_FS has been set, 760 * so it's now or never. 761 * 762 * We don't care if this is a normal syncfs call that does this or 763 * freeze that does this - we can run this multiple times without issue 764 * and we won't race with a restart because a restart can only occur 765 * when the state is either SB_FREEZE_FS or SB_FREEZE_COMPLETE. 766 */ > 767 if (sb->s_writers.frozen == SB_FREEZE_PAGEFAULT) 768 xfs_inodegc_stop(mp); 769 770 return 0; 771 } 772
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |