lkml.org 
[lkml]   [2021]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
On Thu, Aug 5, 2021 at 4:40 PM Matthias Schiffer
<matthias.schiffer@ew.tq-group.com> wrote:
> On Thu, 2021-08-05 at 14:30 +0100, Lee Jones wrote:
> > On Fri, 16 Jul 2021, Matthias Schiffer wrote:

...

> > Strange - why is this !0 in the first place?
>
> I don't see anything strange here. DEFINE_RES_IRQ() sets flags to
> IORESOURCE_IRQ. We reset it to 0 when there is no IRQ to clear that
> resource entry.
>
> An alternative would be to start with an empty entry and only fill in
> the fields when an IRQ is used, but that seems more cumbersome than the
> current code to me.

Another alternative is to start using the IRQ DISABLED resource flag,
but I'm afraid that OF code is not ready for that.
https://elixir.bootlin.com/linux/latest/source/include/linux/ioport.h#L331

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-08-05 15:44    [W:0.046 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site