lkml.org 
[lkml]   [2021]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/7] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set
On Fri, 16 Jul 2021, Matthias Schiffer wrote:

> The driver was registering IRQ 0 when no IRQ was set. This leads to
> warnings with newer kernels.
>
> Clear the resource flags, so no resource is registered at all in this
> case.
>
> Fixes: 2f17dd34ffed ("mfd: tqmx86: IO controller with I2C, Wachdog and GPIO")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
>
> v2: add Fixes line
> v3: no changes
>
> drivers/mfd/tqmx86.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/tqmx86.c b/drivers/mfd/tqmx86.c
> index ddddf08b6a4c..732013f40e4e 100644
> --- a/drivers/mfd/tqmx86.c
> +++ b/drivers/mfd/tqmx86.c
> @@ -209,6 +209,8 @@ static int tqmx86_probe(struct platform_device *pdev)
>
> /* Assumes the IRQ resource is first. */
> tqmx_gpio_resources[0].start = gpio_irq;
> + } else {
> + tqmx_gpio_resources[0].flags = 0;

Strange - why is this !0 in the first place?

> }
>
> ocores_platfom_data.clock_khz = tqmx86_board_id_to_clk_rate(board_id);

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2021-08-05 15:31    [W:0.108 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site